Skip to content

vscode: Support Terminal.state #11733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2022

Conversation

xai
Copy link
Contributor

@xai xai commented Oct 3, 2022

What it does

Add support for indicating and notifying changes on Terminal.state.

Fixes #11515
Contributed on behalf of STMicroelectronics.

How to test

  • Download test extension terminal-state-11515-0.0.1.zip and copy it to the plugins folder
  • Start Theia and run the command Show terminal state that is provided by the test extension
  • Verify that a terminal opens and a notification message with the text Terminal state: { "isInteractedWith": false } is shown
  • Type something into the terminal
  • Verify that a notification message with the text Terminal state has changed: { "isInteractedWith": true } is shown

Review checklist

Reminder for reviewers

Sorry, something went wrong.

Add support for indicating and notifying changes on Terminal.state.

Fixes eclipse-theia#11515
Contributed on behalf of STMicroelectronics.

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
@vince-fugnitto vince-fugnitto added terminal issues related to the terminal vscode issues related to VSCode compatibility labels Oct 4, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality work well for me, I only have minor comments regarding the documentation.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vince-fugnitto vince-fugnitto merged commit be8cb34 into eclipse-theia:master Oct 4, 2022
@vince-fugnitto vince-fugnitto added this to the 1.31.0 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] Support indicating and notifying changes on Terminal.state
2 participants