Contribute GH Build action to platform.ui #151
Conversation
|
You should add the unitest.yml as well ... |
| -Dproject.build.sourceEncoding=UTF-8 | ||
| -Dorg.slf4j.simpleLogger.showDateTime=true | ||
| -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss.SSS | ||
| -DtrimStackTrace=false |
There was a problem hiding this comment.
You might want to add property t not fail on failing tests and using multiple threads.
There was a problem hiding this comment.
I tried to use the same settings as Jenkins build file. We should change both if we want to but I would avoid doing this for the intial contribution.
There was a problem hiding this comment.
do not failed with test ist a requirement for the unitest action to work.
|
You are missing the toolcahins.xml and toolchain maven option. |
As does the Jenkins file |
JIPP auto inject the toolchain.xml so no need to handle it manually. |
Ignore my deleted comment, I saw now that it was silly. |
Adds GH verification in the hope that GH validation is faster than the Jenkins one. Fixes eclipse-platform#150
Why? it doesn't make sense, as it is the complete commandline as jenkins uses some default locations that maven look at... And it would harm because if you specify it manually maven would complain that the file do not exits :-) Hopefully we will get so toolchains are setup automatically at GH, so please vote/comment/complain/... there to get more attention to this PR :-) |
|
Thanks @laeubi and @akurtakov |
Adds GH verification in the hope that GH validation is faster than the
Jenkins one.
Fixes #150