-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make path names UNIX-friendly #1460
base: master
Are you sure you want to change the base?
make path names UNIX-friendly #1460
Conversation
Test Results 930 files + 310 930 suites +310 50m 15s ⏱️ + 24m 2s For more details on these failures, see this check. Results for commit 740e525. ± Comparison against base commit ad1dfcd. ♻️ This comment has been updated with latest results. |
Could you please explain what kind of issue you are trying to fix here? |
changes in a nutshell:
|
when I work on command prompt for pattern searching I don't get comprehensive results
|
Here it is claimed that either the script or the program should be considered buggy then: https://unix.stackexchange.com/questions/148043/is-space-not-allowed-in-a-filename Just in case, Eclipse contains a "search in files" that is much more useful than traditional grep (for me)... |
I've also been bitten by spaces breaking scripts. Of course spaces are not wrong, but they are annoying. And Eclipse search is of course nicer, but not all files are actually visible in the workspace so I too on occasion want to search everything in all the clones... |
I can only second that! Nothing is broken in the current state but with this PR certain things would become easier. |
for example , I was trying to get this pattern for one of my PRs and I was never able to get it straight with the eclipse search
its possible that it can me made to work just that I am more comfortable in command prompt in scenarios like this. |
I'm not that familiar with grep (that's probably because I need an IDE to work ;-)) but if I decode this correctly you want:
Fair enough, given that this gives me hits in literally thousands of places I personally would be really frustrated in matching the results back to my IDE doing the necessary changes, just assuming you want to replace it afterwards, you can even hit "replace" and get a nice preview if you want and so on... |
Is there anything that I can do to make progress on this PR? Thanks . |
I think this change is a good idea. Obviously it needs to be rebased. @iloveeclipse @HeikoKlare @akurtakov I believe no one objects. |
It would be nice if search and workbench changes are split to make it easier to look at changes in a single PR. |
If it would be a PR per bundle, it would be easier to review & approve. |
remove white spaces from path names
I also appreciate this change, as I also find whitespaces in paths annoying, even though being valid. Just one consideration concerning the proposed solution: if all these paths are touched anyway, it might make sense to not only remove the whitespaces in the source folder names but to also re-evaluate if the names are good at all. I have not seen many plug-ins with source folders other than
One specific question regarding the workbench plug-in: are these two source folders ( |
I agree with @HeikoKlare that this seems kind of pointless for the org.eclipse.ui.workbench. In this case it looks like some stalled effort (from 2002) described as "First cut of org.eclipse.ui split". |
Thanks all for the suggestions. Keeping it draft until i rework on this. Meanwhile please review eclipse-platform/eclipse.platform.releng.aggregator#1740 and #1536 |
ba386e6
to
3ec463f
Compare
3ec463f
to
162c01a
Compare
162c01a
to
740e525
Compare
I have separated the bundles and this is ready for review. for some reason I am unable to squash the commits ( |
Please close this PR and create a separate PR for each bundle. I also second the change. |
remove white spaces from path names