Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target platform bundle updates #1769

Merged
merged 1 commit into from Feb 5, 2024
Merged

Conversation

merks
Copy link
Contributor

@merks merks commented Feb 5, 2024

Update assertj-core to 3.25.3.
Update junit-jupiter-* and junit-vintage-engine to 5.10.2. Update junit-platform-* to 1.10.2.

Update assertj-core to 3.25.3.
Update junit-jupiter-* and junit-vintage-engine to 5.10.2.
Update junit-platform-* to 1.10.2.
@merks
Copy link
Contributor Author

merks commented Feb 5, 2024

FYI @akurtakov

Probably JDT's feature will need a forced qualifier change.

image

I'll create a PR in expectation of that.

@merks
Copy link
Contributor Author

merks commented Feb 5, 2024

@akurtakov

I see this in the log:

09:05:48  [INFO] --- tycho-packaging:4.0.5:package-feature (default-package-feature) @ org.eclipse.jdt ---
09:05:48  [INFO] Building jar: /home/jenkins/agent/workspace/atform.releng.aggregator_PR-1769/eclipse.jdt/org.eclipse.jdt-feature/target/org.eclipse.jdt-3.19.400-SNAPSHOT.jar
09:05:48  [INFO] 
09:05:48  [INFO] --- tycho-p2:4.0.5:p2-metadata-default (default-p2-metadata-default) @ org.eclipse.jdt ---
09:05:48  [INFO] No baseline version MavenProject: org.eclipse.jdt.feature:org.eclipse.jdt:3.19.400-SNAPSHOT @ /home/jenkins/agent/workspace/atform.releng.aggregator_PR-1769/eclipse.jdt/org.eclipse.jdt-feature/pom.xml

So it appears that there is no need because the version already changed since the release baseline, which makes me wonder why the test feature always needs special attention...

@merks merks merged commit 837a33f into eclipse-platform:master Feb 5, 2024
4 checks passed
@merks merks deleted the pr-tp-junit branch February 5, 2024 08:21
@akurtakov
Copy link
Member

I can not explain it as in the past features in another repository needed a touch of the feature. Test feature is a standalone feature (not included in product) while jdt is in the product and a top-down approach might show that the newly built feature is needed by the product and thus auto updated but test feature doesn't have such way.

@laeubi
Copy link
Contributor

laeubi commented Feb 5, 2024

The feature qualifier aggregator works in quite an "odd" way I have started in improving it but was not yet able to finish with that:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants