-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add m2e lifecycle metadata for maven-dependency-plugin #1078
Add m2e lifecycle metadata for maven-dependency-plugin #1078
Conversation
Thanks @kwin for this update. Your dedication to spread the BuildContextAPI is really helpful! Do you plan to have a release of the maven-dependency-plugin soon? |
The release should happen soon: https://lists.apache.org/thread/xo0m4dztj0v67rdv4n843ls3dxny66xg |
Great. 👍🏽 |
I'm not sure if an error is appropriate here, why not a warning instead? I assume even with a release there will be some projects that do not update immediately and some older projects that probably never update so all will get an error marker now the user will not really be able to act upon. |
The behaviour should be the same for all Maven plugins, and the existing ones emit an error already (https://github.com/kwin/m2e-core/blob/dbfe0c1fc2538694edc66a61fa404073b5cffd3b/org.eclipse.m2e.core/lifecycle-mapping-metadata.xml#L116). But I agree that most probably all should be changed to a warning. |
A while back we changed missing mappings from error > warning so I think this would be applicable also. Error seems really disturbing to the user given that the only harm that could happen is that nothing happens... |
Yes the behavior should be the same and yes warning should be enough. The relevant code to adjust this is probably That being said, I did not manage to actually get the warning in the Editor. I only got |
I can't think of a use-case where error is anything useful, why should I error the user about my mojo in an IDE? So probably the "error" can just be treated as a warning marker... |
This closes #1077