refactor(api): merge signaling api context into control #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
refactoring
ndr-brt
requested review from
bscholtes1A,
jimmarino,
paullatzelsperger,
ronjaquensel and
juliapampus
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| webService.registerResource(controlApiConfiguration.getContextAlias(), controller); | ||
| registerSignalingContext(controller); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4176 +/- ##
==========================================
+ Coverage 71.74% 75.01% +3.26%
==========================================
Files 919 1012 +93
Lines 18457 20561 +2104
Branches 1037 1160 +123
==========================================
+ Hits 13242 15423 +2181
+ Misses 4756 4630 -126
- Partials 459 508 +49 ☔ View full report in Codecov by Sentry. |
paullatzelsperger
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Merge the
signaling-apicontext into thecontrol-apicontextWhy it does that
we should keep the context number consistent to the ones described in this decision record:
https://github.com/eclipse-edc/Connector/blob/main/docs/developer/decision-records/2022-11-09-api-refactoring/renaming.md
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4175
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.