Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra comment for gitlab bot post instruction #37

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

heurtematte
Copy link
Contributor

Recommendation on Jenkinsfile and multibranch pipeline.

Taking for example: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4592

Signed-off-by: sebastien.heurtematte <sebastien.heurtematte@eclipse-foundation.org>
@@ -102,6 +102,10 @@ Post the following on the corresponding HelpDesk issue:
A GitLab bot user for ${PROJECT_NAME} has been created, along with credentials that have been added to the CI instance (SSH credentials ID: \`gitlab-bot-ssh\`).
A webhook that will trigger CI jobs has been added as well.

As part of our [jenkins pipeline best practice](https://github.com/eclipse-cbi/jiro/wiki/Jenkins#jenkins-pipeline-best-practices), we encourage following recommendations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Jenkins pipeline best practices] and we encourage the following

Signed-off-by: sebastien.heurtematte <sebastien.heurtematte@eclipse-foundation.org>
@fredg02
Copy link
Contributor

fredg02 commented Apr 26, 2024

Slight misunderstanding, the sentence should be this:

As part of our [Jenkins pipeline best practices](https://github.com/eclipse-cbi/jiro/wiki/Jenkins#jenkins-pipeline-best-practices), we encourage the following recommendations:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants