Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide contributors with an Oomph Setup to simplify setup of a BIRT IDE #596

Closed
Flugtiger opened this issue Mar 5, 2021 · 9 comments
Closed
Milestone

Comments

@Flugtiger
Copy link
Contributor

I have an Oomph setup file laying around in my fork and would love to integrate it into the real deal (and maybe even get it into the official Oomph catalogue). 馃榿 I just have to find the time to create the necessary pull requests...

@wimjongman wimjongman added this to the 4.9 milestone Mar 7, 2021
@UrsZeidler
Copy link
Contributor

We at @SerNet would appreciate this.

ruspl-afed added a commit that referenced this issue Oct 31, 2021
Initial edition provided by Ed @merks

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit that referenced this issue Oct 31, 2021
Added branding
Installed m2e
Changed "no baseline" to warning
Moved JRETask to master stream

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@ruspl-afed
Copy link
Contributor

ruspl-afed commented Oct 31, 2021

Ed @merks is it possible to add maven dependency to setup.targlets:TargletTask ? I can found how to reference the .target file to be activated but nothing about Maven artifacts.

We have a number of dependencies in the form:

		<location includeDependencyScope="compile" includeSource="true" missingManifest="generate" type="Maven">
			<groupId>org.eclipse.jetty</groupId>
			<artifactId>jetty-server</artifactId>
			<version>10.0.6</version>
			<type>jar</type>
		</location>

How would you handle this with Oomph?

I also asked here
https://www.eclipse.org/forums/index.php/m/1847541/#msg_1847541

ruspl-afed added a commit that referenced this issue Oct 31, 2021
Move incomplete targlet to disabled stream
Correct oomph redirection
Add project import
Add pde:TargetPlatformTask (does not activate target for some reason)

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@merks
Copy link
Contributor

merks commented Nov 1, 2021

Sorry, there is no support for that. Ideally someone would simply generate a Jetty update site that everyone can reuse, but that appears to be wishful thinking with both the Platform and WTP spinning such things, but only for the parts they respectively need.

@merks
Copy link
Contributor

merks commented Nov 1, 2021

I did a bit of digging and found these:

jetty/jetty.project#6403
jetty/jetty.project#6404

So I found that these p2 update sites exist:

https://search.maven.org/artifact/org.eclipse.jetty/jetty-p2

These can be used directly by p2 using a URL like this:

jar:https://repo1.maven.org/maven2/org/eclipse/jetty/jetty-p2/10.0.7/jetty-p2-10.0.7-p2site.zip!/

But resolution fails because

  ERROR: org.eclipse.equinox.p2.director code=0 Software being installed: artificial_root 1.0.0.v1635751513019
  ERROR: org.eclipse.equinox.p2.director code=0 Missing requirement: org.eclipse.birt.rcp.feature.group 4.9.0.v20211101-082503 requires 'org.eclipse.equinox.p2.iu; org.eclipse.jetty.continuation 0.0.0' but it could not be found
  ERROR: org.eclipse.equinox.p2.director code=1 Cannot satisfy dependency:
    ERROR: org.eclipse.equinox.p2.director code=0 From: artificial_root 1.0.0.v1635751513019

If I remove that dependency, it gets further, but fails like this:

  ERROR: org.eclipse.equinox.p2.engine code=0 session context was:(profile=D__Users_test_birt-master_ws-1f7da47122711d3168e64bbe8212f2ea91b32f67, phase=org.eclipse.equinox.internal.p2.engine.phases.Collect, operand=, action=).
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.deploy,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.http,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.io,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.jndi,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.osgi.boot,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.plus,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.security,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.server,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.servlet,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.util,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.webapp,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.
  ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Problems downloading artifact: osgi.bundle,org.eclipse.jetty.xml,10.0.7.
    ERROR: org.eclipse.equinox.p2.artifact.repository code=0 Signature is invalid for current content.

So that doesn't look so good...

The above is an error from the new PGP signature verification that is produced here:

https://git.eclipse.org/c/equinox/rt.equinox.p2.git/tree/bundles/org.eclipse.equinox.p2.artifact.repository/src/org/eclipse/equinox/internal/p2/artifact/processors/pgp/PGPSignatureVerifier.java#n222

A bug?

Perhaps a location in a *.target file doesn't do any verification?

@merks
Copy link
Contributor

merks commented Nov 1, 2021

Investigating locally in an Oomph runtime instance I get a failure like this:

    ERROR: org.eclipse.equinox.p2.engine code=0 session context was:(profile=D__Users_merks_oomph-1.23_ws-IDE-0f0cce59e727abd0ac508a95d9159270dc7fb384, phase=org.eclipse.equinox.internal.p2.engine.phases.Collect, operand=, action=).
    ERROR: org.eclipse.equinox.p2.transport.ecf code=1002 Unable to read repository at mvn:org.eclipse.jetty:jetty-util:10.0.7:jar:.

So clearly I'm missing the thing that registers the mvn protocol...

@ruspl-afed
Copy link
Contributor

Ed @merks please also have a look at my PR #677
I tried to use pde:TargetPlatformTask (that could postpone our battle with Jetty) but the .target is not activated for some reason (https://github.com/eclipse/birt/pull/677/files#r740025382 ).
I'm using target file name without .target extension.

ruspl-afed added a commit that referenced this issue Nov 1, 2021
Use target name for pde:TargetPlatformTask

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@wimjongman
Copy link
Contributor

Guys, jetty is in the target platform. That needs to be activated.

@ruspl-afed
Copy link
Contributor

ruspl-afed added a commit that referenced this issue Nov 1, 2021
Add information to README.MD

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit that referenced this issue Nov 1, 2021
Convert README.MD back to LF

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
ruspl-afed added a commit that referenced this issue Nov 1, 2021
Convert README.MD back to CRLF

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
wimjongman pushed a commit that referenced this issue Nov 4, 2021
* Provide Oomph Setup to simplify setup of a BIRT IDE #596

Initial edition provided by Ed @merks

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>

* Provide Oomph Setup to simplify setup of a BIRT IDE #596

Added branding
Installed m2e
Changed "no baseline" to warning
Moved JRETask to master stream

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>

* Provide Oomph Setup to simplify setup of a BIRT IDE #596

Move incomplete targlet to disabled stream
Correct oomph redirection
Add project import
Add pde:TargetPlatformTask (does not activate target for some reason)

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>

* Provide Oomph Setup to simplify setup of a BIRT IDE #596

Use target name for pde:TargetPlatformTask

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>

* Provide Oomph Setup to simplify setup of a BIRT IDE #596

Add information to README.MD

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>

* Provide Oomph Setup to simplify setup of a BIRT IDE #596

Convert README.MD back to LF

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>

* Provide Oomph Setup to simplify setup of a BIRT IDE #596

Convert README.MD back to CRLF

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@wimjongman
Copy link
Contributor

This one was fixed. Thanks all for pushing this. An important step forward.

Please use the new installer link and follow the instructions. The link is also available from the README.MD:

https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse/birt/master/build/org.eclipse.birt.releng/BIRTConfiguration.setup&show=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants