Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build because of missing Jetty dependency #110

Closed
debovema opened this issue Nov 4, 2021 · 4 comments · Fixed by #111
Closed

Unable to build because of missing Jetty dependency #110

debovema opened this issue Nov 4, 2021 · 4 comments · Fixed by #111

Comments

@debovema
Copy link

debovema commented Nov 4, 2021

When running ./build.sh the Maven build fails because of this:

[INFO] Adding repository https://download.eclipse.org/jetty/updates/jetty-bundles-9.x/9.4.43.v20210629
[ERROR] Failed to resolve target definition /home/mathieu/glsp/ecore-glsp/server/targetplatform/ecore-server.target: Failed to load p2 metadata repository from location https://download.eclipse.org/jetty/updates/jetty-bundles-9.x/9.4.43.v20210629/: No repository found at https://download.eclipse.org/jetty/updates/jetty-bundles-9.x/9.4.43.v20210629.

@ndoschek : I noticed you already had such an issue in eclipse-emfcloud/emfcloud-modelserver#125

It seems that Jetty is no longer provided as a p2 update site, isn't it ?

@CamilleLetavernier
Copy link
Member

It seems that the Jetty P2 repo has been aggressively cleaned-up when they released a new version.

The current one is: https://download.eclipse.org/jetty/updates/jetty-bundles-9.x/9.4.44.v20210927/

The repository doesn't seem to contain composite metadata, so we can't use a more stable repository such as https://download.eclipse.org/jetty/updates/jetty-bundles-9.x/. I suspect we'll have to update the target platform regularly.

CamilleLetavernier added a commit that referenced this issue Nov 5, 2021
- Update the jetty P2 repo URL in the target platform

fixes #110
@debovema
Copy link
Author

debovema commented Nov 5, 2021

Thanks for the explanation and the fix.
I was confused because of the missing composite metadata. Btw how did you find the actual version ?

It seems related to jetty/jetty.project#6403. Jetty maintainers introduced the new feature to distribute p2 update site as standard Maven artifacts.
However this applies only to 10.x and 11.x whereas GLSP uses the 9.x branch.
Moreover the declaration are done in the .target files but there are currently no support in .tpd files (used here for instance) nor in Oomph targlets (see eclipse-birt/birt#596).

@CamilleLetavernier
Copy link
Member

Btw how did you find the actual version ?

Most Eclipse P2 repos list their contents, so if you go one or two level ups from a P2 repo URL, you can see related files (including repositories). So I simply checked https://download.eclipse.org/jetty/updates/jetty-bundles-9.x/ (With a web-browser)

It seems related to jetty/jetty.project#6403. Jetty maintainers introduced the new feature to distribute p2 update site as standard Maven artifacts.

Indeed, we should consider updating Jetty and use the Maven P2 repos. I'll check with the other EMF.Cloud projects to see if this can be done.

@debovema
Copy link
Author

debovema commented Nov 5, 2021

OK I'm pretty sure that I checked https://download.eclipse.org/jetty/updates/jetty-bundles-9.x/ and that it was empty. Anyway the fact that this update site is not "stable" will cause the same issue in some weeks/months.

Closing but interested in future issues to keep track of changes in this repository and in eclipse-emfcloud / eclipse-glsp about this topic. IMHO some other dependencies in "unstable" should be using this new paradigm of p2 update site as standard Maven artifacts (when available).

@debovema debovema closed this as completed Nov 5, 2021
ndoschek added a commit that referenced this issue Nov 8, 2021
110: Unable to build because of missing Jetty dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants