Add support for partially signed tx, closes #38 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safanaj
commented
Nov 15, 2022
•
safanaj
commented
- allow to set additional witnesses for partially signed tx preparation
- change calculateMinFee to consider additional witnesses that will increase the tx length. It is still not clear how to precisely calculate the bytes for witnesses, in this implementation for each additional witnesses there will be an additional 100 bytes, (32 public key, 64 signature, 4 index/key in cbor). Those are not actually enough so we are considering 1 additional byte for each additional witness after the first.
* allow to set additional witnesses for partially signed tx preparation * change calculateMinFee to consider additional witnesses that will increase the tx length. It is still not clear how to precisely calculate the bytes for witnesses, in this implementation for each additional witnesses there will be an additional 100 bytes, (32 public key, 64 signature, 4 index/key in cbor). Those are not actually enough so we are considering 1 additional byte for each additional witness after the first.
|
ping @echovl |
echovl
reviewed
Dec 14, 2022
tx_builder.go
Outdated
| @@ -143,6 +151,14 @@ func (tb *TxBuilder) MinCoinsForTxOut(txOut *TxOutput) Coin { | |||
| func (tb *TxBuilder) calculateMinFee() Coin { | |||
| txBytes := tb.tx.Bytes() | |||
| txLength := uint64(len(txBytes)) | |||
| // for each additional witnesses there will be an additional 100 bytes, | |||
| // (32 public key, 64 signature, 4 index/key in cbor) | |||
| txLength += uint64(tb.additionalWitnesses * 100) | |||
There was a problem hiding this comment.
instead of doing this, we could just encode the tx using placeholder witnesses keys so we can have an accurate tx length
There was a problem hiding this comment.
hey @echovl do you mean adding some "fake" xprvkey with .Sign ? not sure how to do that and/or to get your idea.
There was a problem hiding this comment.
Hi @echovl I think I got your point, now in the calculateMinFee the additional witnesses are temporary added just to compute the length, the size of VKey and Signature are literal, those could be get from github.com/echovl/ed25519 but I didn't add that import just for 32 and 64 literals.
Signed-off-by: Marco Bardelli <bardelli.marco@gmail.com>
Signed-off-by: Marco Bardelli <bardelli.marco@gmail.com>
|
ping @echovl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.