Expose encoding facility, closes #37 #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safanaj
commented
Nov 15, 2022
•
safanaj
commented
- expose bech32 module for easy marshalling
- added support for stake addresses
- added convinient method to build stake credential from key hash
|
ping @echovl |
* expose bech32 module for easy marshalling * added convinient method to build stake credential from key hash Signed-off-by: Marco Bardelli <bardelli.marco@gmail.com>
safanaj
force-pushed
the
feature/issue-37
branch
from
ca21a63
to
8011af7
Compare
|
@echovl @kevink1103 I updated this PR removing the addition of StakeAddress type as we agreed to prefer #46 . |
safanaj
changed the title
|
@safanaj looks ok to me but it needs some unit tests, that also will help to document the usage. |
|
Hi @echovl , do you mean unit tests to demonstrate how to implement Bech32Codec and Bech32Encoder interfaces? |
Signed-off-by: Marco Bardelli <bardelli.marco@gmail.com>
|
@echovl I added some unit tests, let me know if that is ok for you, eventually we can add more of them to have a really exhaustive test suite. |
Signed-off-by: Marco Bardelli <bardelli.marco@gmail.com>
|
ping @echovl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.