Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): upgrade to 5.3 - INNO-2075 #1520

Merged
merged 6 commits into from Jan 30, 2020

Conversation

kalinchernev
Copy link
Contributor

@kalinchernev kalinchernev commented Jan 24, 2020

PR description

Ensure clear re-installation. (rm -rf node_modules + yarn install)

Local development with yarn start:ec and yarn start:eu should have no issues, as well as build (validated already by the CI)

@kalinchernev kalinchernev changed the title chore(storybook): start upgrade to 5.3 - INNO-2075 chore(storybook): upgrade to 5.3 - INNO-2075 Jan 27, 2020
Copy link
Contributor

@emeryro emeryro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall it seems fine, I just have an issue when running yarn start:ec: instead of opening the localhost url in the browser (as it is on v2-dev), I get this error
image
("Windows does not find '\http://localhost:6006/\'. Check you entered the correct name and try again.")
That's not a blocker, but if you have any idea how to solve it that may be fine

@emeryro emeryro removed their assignment Jan 29, 2020
@kalinchernev
Copy link
Contributor Author

kalinchernev commented Jan 30, 2020

@emeryro I managed to reproduce the issue in WSL 1 and debugging it, turns out that storybook's start script uses opn which is now open under the hood.

There are known issues with Windows and I tried to patch the version of opn and open to have latest fixes but these don't help.

Also, there is an open issue with relation to the exact issue here sindresorhus/open#154

In summary, the issue is not coming from storybook itself, but open package and how the host OS opens default browser.

In my case, this code

const open = require("open");

(async () => {
  // Opens the URL in the default browser.
  await open("http://localhost:6000");
})();

Worked well in Linux, but didn't do anything in WSL, because it's treated as Linux but there seems to be no link between host and subsystem.

Copy link
Contributor

@papegaill papegaill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no issue running yarn start:ec, successfully tested on IE11 and Edge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants