Fix namespace issue for BinarySecurityToken tag #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffcarbs
force-pushed
the
fix-binary-security-token-node
branch
from
21cc9ae
to
a53e600
Compare
bpietraga
reviewed
Aug 17, 2021
Co-authored-by: Bernard Pietraga <16989065+bpietraga@users.noreply.github.com>
|
👍 |
|
Running this patch against a test in our system works, but for some reason #31 is still producing a BinarySecurityToken tag without the namespace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In nokogiri
1.12.0the following change was introduced:It seems like the
BinarySecurityTokenwas implicitly relying on this to add thewsse:prefix which is no longer happening. This PR fixes it by explicitly adding the namespace.