#45 Use Unsafe instantiator on JDK9 #46
Conversation
|
When this issue is resolved it would be great to have org.objenesis:objenesis:2.5 released :) |
|
Thanks. I should be able to have a look and release in about a week |
| // times slower. So I prefer to use this one | ||
| return new SunReflectionFactoryInstantiator<T>(type); | ||
| if (PlatformDescription.VM_VERSION.startsWith("9")) { | ||
| // UnsafeFactoryInstantiator doesn't work on JDK9 anymore |
There was a problem hiding this comment.
Isn't this comment contradictory? 'UnsafeFactoryInstantiator doesn't work in JDK9, so let's use it!'
There was a problem hiding this comment.
Indeed. Is it Unsafe or ReflectionFactory that doesn't work?
There was a problem hiding this comment.
Ouch, copy-paste error :( Of course comment should be:
// SunReflectionFactoryInstantiator doesn't work on JDK9 anymore
|
The method will be resuscitated so false alarm, see: |
|
Funny. Let's consider this unneeded then. Thanks for the alert, the patch, the investigation and the follow-up |
Proposal solution for issue #45