Add cache for mocked types. #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the proposal and the benchmark. I'll look deeper into it. ByteBuddy can't cache by itself? I was looking for that. |
|
ByteBuddy just provide TypeCache and developer should himself implement caching by its own needs. |
|
I will decline this one because it's superseded by #353. But I'm reusing the idea. Thanks a lot for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to add cache for mocked types because class generation through ByteBuddy is expensive. In my project 5.0.1 is 2x slower than 4.3. With this patch 5.0.1 slightly slower (or equals I don't measured fine) than 4.3.