Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): update secrets #14

Merged
merged 6 commits into from
Oct 13, 2023
Merged

fix(middleware): update secrets #14

merged 6 commits into from
Oct 13, 2023

Conversation

ido-pluto
Copy link
Collaborator

  • option to edit cookie/session secret
  • custom express session storage
  • bump version of dependencies

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (941b5ee) 80.92% compared to head (d8e0fb5) 81.35%.

❗ Current head d8e0fb5 differs from pull request most recent head 2b9e74b. Consider uploading reports for the commit 2b9e74b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   80.92%   81.35%   +0.43%     
==========================================
  Files          95       95              
  Lines       10366    10391      +25     
  Branches      962      961       -1     
==========================================
+ Hits         8389     8454      +65     
+ Misses       1950     1910      -40     
  Partials       27       27              
Files Coverage Δ
src/MainBuild/Settings.ts 79.05% <72.56%> (-0.95%) ⬇️

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ido-pluto ido-pluto merged commit 189cd42 into master Oct 13, 2023
3 checks passed
@ido-pluto ido-pluto deleted the fix/settings branch October 13, 2023 10:47
@github-actions
Copy link

🎉 This PR is included in version 1.5.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant