Prepare release #94
Prepare release #94
Conversation
We might want to use the modern technologies and standards for describing project metadata like PEP-517, PEP-518 and PEP-621. This is a first step and already seems to work very well.
|
Thanks a bunch for all your excellent work on this. I will start a review process, let's check what comes up. |
| python-version: 3.8 | ||
| architecture: x64 | ||
| - run: pip install nox==2019.11.9 | ||
| - run: pip install poetry==1.0.5 |
There was a problem hiding this comment.
Within the other workflow, there's already pip install poetry==1.0.9.
| with: | ||
| python-version: 3.8 | ||
| architecture: x64 | ||
| - run: pip install nox==2019.11.9 |
There was a problem hiding this comment.
Within the other workflow, there's already pip install nox==2020.5.24.
| architecture: x64 | ||
| - run: pip install nox==2019.11.9 | ||
| - run: pip install poetry==1.0.5 | ||
| - run: nox |
| codecov = "^2.1.7" | ||
|
|
||
| [tool.poetry.scripts] | ||
| dwd = 'python_dwd.cli:run' |
There was a problem hiding this comment.
Please say wetterdienst = wetterdienst.cli:run here.
| assert remote_file_path[DWDMetaColumns.FILENAME.value].tolist() == ['daily/kl/recent/tageswerte_KL_01048_akt.zip'] | ||
| assert remote_file_path == ['daily/kl/recent/tageswerte_KL_01048_akt.zip'] |
| # Single-sourcing the package version | ||
| # https://cjolowicz.github.io/posts/hypermodern-python-06-ci-cd/ | ||
| try: | ||
| from importlib.metadata import version, PackageNotFoundError # type: ignore | ||
| except ImportError: # pragma: no cover | ||
| from importlib_metadata import version, PackageNotFoundError # type: ignore |
There was a problem hiding this comment.
Good to see this seems to work now. Even with the special fallback for Python 3.6 and 3.7.
|
Please also check #95. I tried to rebase the branch on top of current master and resolved all conflicts which came up, always choosing
|
|
Superseded by #95. |
I prepared the release to PyPi. I renamed the library, added a release Github action, updated the readme and added minor changes.