Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BK for new inline cache (won't merge) #4112

Closed
wants to merge 1 commit into from

Conversation

mikejholly
Copy link
Contributor

@mikejholly mikejholly commented May 14, 2024

BuildKit PR: earthly/buildkit#60

@mikejholly mikejholly changed the title Update BuildKit hash Update BK for new inline cache May 14, 2024
@mikejholly mikejholly changed the title Update BK for new inline cache Update BK for new inline cache (won't merge) May 16, 2024
@mikejholly mikejholly force-pushed the mh/bk-inline-cache branch 5 times, most recently from 7d8de95 to 5130b38 Compare May 16, 2024 20:25
Copy link
Collaborator

@alexcb alexcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're going to need to figure out a way to build both earthly-main and earthly-next versions for use in testing.

#4117 tackles building and pushing both images, but that won't cover being able to execute our tests on both copies, which I think we need to do.

@mikejholly
Copy link
Contributor Author

we're going to need to figure out a way to build both earthly-main and earthly-next versions for use in testing.

#4117 tackles building and pushing both images, but that won't cover being able to execute our tests on both copies, which I think we need to do.

Agreed. We'll need to come up with something here soon.

@alexcb
Copy link
Collaborator

alexcb commented May 17, 2024

I wonder if we could just have GHA do a earthly +update-buildkit --BUILDKIT_GIT_SHA=$(cat earthly-next-sha-to-use) before running +for-linux?

then all we need to do is create a file called earthly-next-sha-to-use in the git repo, and update the commit there?

(this is a temporary solution while we have two different branches to maintain)

@mikejholly mikejholly closed this May 17, 2024
@mikejholly mikejholly deleted the mh/bk-inline-cache branch May 17, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants