Skip to content

Commit

Permalink
Adjust some minor details of google#1391.
Browse files Browse the repository at this point in the history
Use two-space indentation for the new test.
Use standard Google import style.
Supply missing type argument for `TypeVariable`.
  • Loading branch information
eamonnmcmanus committed Aug 3, 2021
1 parent d65960b commit 425cb25
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 31 deletions.
6 changes: 3 additions & 3 deletions gson/src/main/java/com/google/gson/internal/$Gson$Types.java
Expand Up @@ -339,13 +339,13 @@ public static Type[] getMapKeyAndValueTypes(Type context, Class<?> contextRawTyp
}

public static Type resolve(Type context, Class<?> contextRawType, Type toResolve) {
return resolve(context, contextRawType, toResolve, new HashMap<TypeVariable, Type>());
return resolve(context, contextRawType, toResolve, new HashMap<TypeVariable<?>, Type>());
}

private static Type resolve(Type context, Class<?> contextRawType, Type toResolve,
Map<TypeVariable, Type> visitedTypeVariables) {
Map<TypeVariable<?>, Type> visitedTypeVariables) {
// this implementation is made a little more complicated in an attempt to avoid object-creation
TypeVariable resolving = null;
TypeVariable<?> resolving = null;
while (true) {
if (toResolve instanceof TypeVariable) {
TypeVariable<?> typeVariable = (TypeVariable<?>) toResolve;
Expand Down
@@ -1,54 +1,55 @@
package com.google.gson.functional;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;

import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
import org.junit.Before;
import org.junit.Test;

import java.util.Collection;
import java.util.Iterator;
import java.util.Set;

import static org.junit.Assert.*;

/**
* This test covers the scenario described in #1390 where a type variable needs to be used
* by a type definition multiple times. Both type variable references should resolve to the
* same underlying concrete type.
*/
public class ReusedTypeVariablesFullyResolveTest {

private Gson gson;
private Gson gson;

@Before
public void setUp() {
gson = new GsonBuilder().create();
}
@Before
public void setUp() {
gson = new GsonBuilder().create();
}

@SuppressWarnings("ConstantConditions") // The instances were being unmarshaled as Strings instead of TestEnums
@Test
public void testGenericsPreservation() {
TestEnumSetCollection withSet = gson.fromJson("{\"collection\":[\"ONE\",\"THREE\"]}", TestEnumSetCollection.class);
Iterator<TestEnum> iterator = withSet.collection.iterator();
assertNotNull(withSet);
assertNotNull(withSet.collection);
assertEquals(2, withSet.collection.size());
TestEnum first = iterator.next();
TestEnum second = iterator.next();
@SuppressWarnings("ConstantConditions") // The instances were being unmarshaled as Strings instead of TestEnums
@Test
public void testGenericsPreservation() {
TestEnumSetCollection withSet = gson.fromJson("{\"collection\":[\"ONE\",\"THREE\"]}", TestEnumSetCollection.class);
Iterator<TestEnum> iterator = withSet.collection.iterator();
assertNotNull(withSet);
assertNotNull(withSet.collection);
assertEquals(2, withSet.collection.size());
TestEnum first = iterator.next();
TestEnum second = iterator.next();

assertTrue(first instanceof TestEnum);
assertTrue(second instanceof TestEnum);
}
assertTrue(first instanceof TestEnum);
assertTrue(second instanceof TestEnum);
}

enum TestEnum { ONE, TWO, THREE }
enum TestEnum { ONE, TWO, THREE }

private static class TestEnumSetCollection extends SetCollection<TestEnum> {}
private static class TestEnumSetCollection extends SetCollection<TestEnum> {}

private static class SetCollection<T> extends BaseCollection<T, Set<T>> {}
private static class SetCollection<T> extends BaseCollection<T, Set<T>> {}

private static class BaseCollection<U, C extends Collection<U>>
{
public C collection;
}
private static class BaseCollection<U, C extends Collection<U>>
{
public C collection;
}

}

0 comments on commit 425cb25

Please sign in to comment.