Branch for eXist 5.3.0

[claudius108]

No description provided.

[adamretter]

@claudius108 Something doesn't seem quite right with this PR... from which branch are you trying to send the updates? Perhaps I could help?

[claudius108]

I wanted a PR from claudius108:eXist-5.3.0 to eXist-db:eXist-5.3.0, but I did to eXist-db:master.

[joewiz]

@claudius108 I see there are some conflicts. Will you be able to address this, or do you need assistance?

[claudius108]

Hi,

There are some changes that I have to include in my branch. I will try to do this.

[line-o]

These to functions are duplicates in an XQuery context because their types are not taken into account only the number of arguments:

    arity(
        FS_GENERATE_SIGNATURE_PARAM_DATA,
        FS_GENERATE_SIGNATURE_PARAM_CANONICALIZATION_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_DIGEST_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_NAMESPACE_PREFIX,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_TYPE,
        FS_GENERATE_SIGNATURE_PARAM_XPATH
    ),
    arity(
        FS_GENERATE_SIGNATURE_PARAM_DATA,
        FS_GENERATE_SIGNATURE_PARAM_CANONICALIZATION_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_DIGEST_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_NAMESPACE_PREFIX,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_TYPE,
        FS_GENERATE_SIGNATURE_PARAM_DIGITAL_CERTIFICATE
    ),

[line-o]

These are the signatures that the baseX implementation provides:

https://docs.basex.org/wiki/Cryptographic_Module

crypto:generate-signature(
  $input as node(), 
  $canonicalization as xs:string, 
  $digest as xs:string, 
  $signature as xs:string, 
  $prefix as xs:string, 
  $type as xs:string
) as node()

crypto:generate-signature(
  $input as node(),
  $canonicalization as xs:string,
  $digest as xs:string,
  $signature as xs:string,
  $prefix as xs:string,
  $type as xs:string,
  $xpath as xs:string,
  $certificate as node()
) as node()

crypto:generate-signature(
  $input as node(),
  $canonicalization as xs:string,
  $digest as xs:string,
  $signature as xs:string,
  $prefix as xs:string,
  $type as xs:string,
  $ext as item()
) as node()

[line-o]

this signature of generate-signature should expect 8 parameters instead of 7

arity(
        FS_GENERATE_SIGNATURE_PARAM_DATA,
        FS_GENERATE_SIGNATURE_PARAM_CANONICALIZATION_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_DIGEST_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_NAMESPACE_PREFIX,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_TYPE,
        == Missing XPATH ==,
        FS_GENERATE_SIGNATURE_PARAM_DIGITAL_CERTIFICATE
    ),

according to the baseX implementation

crypto:generate-signature(
  $input as node(),
  $canonicalization as xs:string,
  $digest as xs:string,
  $signature as xs:string,
  $prefix as xs:string,
  $type as xs:string,
  $xpath as xs:string,
  $certificate as node()
) as node()

should be

arity(
        FS_GENERATE_SIGNATURE_PARAM_DATA,
        FS_GENERATE_SIGNATURE_PARAM_CANONICALIZATION_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_DIGEST_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_ALGORITHM,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_NAMESPACE_PREFIX,
        FS_GENERATE_SIGNATURE_PARAM_SIGNATURE_TYPE,
        FS_GENERATE_SIGNATURE_PARAM_XPATH,
        FS_GENERATE_SIGNATURE_PARAM_DIGITAL_CERTIFICATE
    ),

[line-o]

What are all these empty files for?

[joewiz]

Related: expath/expath-cg#132.

[line-o]

development will be picked up by the existdb community