Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links to GRDC pages #413

Merged
merged 2 commits into from May 7, 2024
Merged

Fix links to GRDC pages #413

merged 2 commits into from May 7, 2024

Conversation

BSchilperoort
Copy link
Contributor

@BSchilperoort BSchilperoort commented May 6, 2024 •
edited

Closes #411

Found another 404 link in observations, fixed it too.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sverhoeven
sverhoeven approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job reducing the open issues.

Links all work.

While testing created #414

@BSchilperoort
Copy link
Contributor Author

Thanks for the review!

@BSchilperoort BSchilperoort merged commit e55036f into main May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverhoeven sverhoeven sverhoeven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead link to GRDC in system setup instructions
2 participants
@BSchilperoort @sverhoeven