change InputError to KeyError

[Daafip]

Missed the Bart's last comment in #407 :||, this works better if we can actually see the sonar could test

[Daafip]

I was hoping more for something like a webpage listing the basin_id's together with river/basin names, country, etc. I guess that doesn't exist?

Shall I also add a link to these maps with the basin_ids? https://github.com/Daafip/caravan-map

[BSchilperoort]

I was also working on fixing some things yesterday, see 876efe8
Perhaps you can merge those changes. I was making the get_basin_id function a classmethod, as that's how it was described in the docstring.

Shall I also add a link to these maps with the basin_ids? https://github.com/Daafip/caravan-map

Could be nice, yes. But perhaps better if you can host it on github pages. Perhaps moving it to the ewatercycle org might also be better. Also see the issue I opened Daafip/caravan-map#1

[Daafip]

But perhaps better if you can host it on github pages. Perhaps moving it to the ewatercycle org might also be better

https://www.ewatercycle.org/caravan-map/ Done!

Do you have any suggestions for the index page?

[BSchilperoort]

Do you have any suggestions for the index page?

I think if you copy part of the README there that would be good. Some explanation why the map exists (to explore and find basin IDs). And put in some relevant links to e.g. the ewatercycle documentation.

[Daafip]

function a classmethod

How do I then mock the function if its a class method?

[BSchilperoort]

function a classmethod

How do I then mock the function if its a class method?

I believe just with mock.patch.
https://stackoverflow.com/a/53485182

[Daafip]

function a classmethod

How do I then mock the function if its a class method?

I believe just with mock.patch. https://stackoverflow.com/a/53485182

Ah, issue with my local unit testing and having the correct version

[Daafip]

Tried to fix the test coverage but don't think a higher coverage is easily met as most of uncovered is downloading files..

[BSchilperoort]

Just two minor comments. Feel free to merge once these are resolved.

With the downloading writing sensible tests can be difficult. But I think this file is sufficiently covered now. The file has an 85% coverage, sonarcloud just doesn't like that some of the changed lines in this PR aren't covered (the measure is per PR, not per file...)

[sonarcloud]

Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud