Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds black and pre-commit hooks #239

Merged
merged 35 commits into from Aug 20, 2021
Merged

Adds black and pre-commit hooks #239

merged 35 commits into from Aug 20, 2021

Commits on Aug 10, 2021

  1. Moved /ewatercycle to /src/ewatercycle + adjust config to match 

    Refs #228
    @sverhoeven
    sverhoeven committed Aug 10, 2021
    Copy the full SHA
    03bf430 View commit details
    Browse the repository at this point in the history

  2. Add black to dev deps 

    Replaces yapf as formatter
    @sverhoeven
    sverhoeven committed Aug 10, 2021
    Copy the full SHA
    910c075 View commit details
    Browse the repository at this point in the history

  3. Configure black to also format notebooks

    @sverhoeven
    sverhoeven committed Aug 10, 2021
    Copy the full SHA
    9607f3e View commit details
    Browse the repository at this point in the history

  4. Added black and friends as pre-commit hooks and to ci

    @sverhoeven
    sverhoeven committed Aug 10, 2021
    Copy the full SHA
    bd3d472 View commit details
    Browse the repository at this point in the history

  5. Files changes by pre-commit run --all-files command

    @sverhoeven
    sverhoeven committed Aug 10, 2021
    Copy the full SHA
    d9a6fa5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Use nbqa-black to format notebooks instead of black 

    As black replaces " with ', which makes invalid JSON
    @sverhoeven
    sverhoeven committed Aug 11, 2021
    Copy the full SHA
    b3f7013 View commit details
    Browse the repository at this point in the history

  2. On release run pre-commit on all files

    @sverhoeven
    sverhoeven committed Aug 11, 2021
    Copy the full SHA
    565eb19 View commit details
    Browse the repository at this point in the history

  3. Disable flake8 until its errors are fixed

    @sverhoeven
    sverhoeven committed Aug 11, 2021
    Copy the full SHA
    ca821b6 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into 111-black

    @sverhoeven
    sverhoeven committed Aug 11, 2021
    Copy the full SHA
    c6b42e7 View commit details
    Browse the repository at this point in the history

  5. Added flake8 plugins 

    Selection from https://towardsdatascience.com/static-code-analysis-for-python-bdce10b8d287
    @sverhoeven
    sverhoeven committed Aug 11, 2021
    Copy the full SHA
    22adbe7 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Make isort, pylint and flake8 compatible with black 

    See https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html
    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    107afa5 View commit details
    Browse the repository at this point in the history

  2. Use tabs in makefile

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    9141a5d View commit details
    Browse the repository at this point in the history

  3. Replace prospector with pre-commit

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    ba8cba8 View commit details
    Browse the repository at this point in the history

  4. Prefer @pytest.fixture over @pytest.fixture()

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    7a4bab4 View commit details
    Browse the repository at this point in the history

  5. Added pylint and bunch of flake8 plugins to pre commit config 

    Using YAML anchor + alias for nb
    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    7f27ade View commit details
    Browse the repository at this point in the history

  6. Move config from arg to file + pytest-fixture config inverted

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    33cafd1 View commit details
    Browse the repository at this point in the history

  7. Disable pylint and fix flake8 errors first

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    13d2d42 View commit details
    Browse the repository at this point in the history

  8. Ignore docstring checks in tests/ + Move google doc style to where py… 

    …docstyle expects it
    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    c74b2f5 View commit details
    Browse the repository at this point in the history

  9. Fix flake8 errors

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    35afd99 View commit details
    Browse the repository at this point in the history

  10. Reduce flake8 warnings

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    096ea90 View commit details
    Browse the repository at this point in the history

  11. Fix doc generator + Fix bunch of lint warnings

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    59abbe3 View commit details
    Browse the repository at this point in the history

  12. More of the same

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    05938c8 View commit details
    Browse the repository at this point in the history

  13. Fixing lint errors in grdc 

    Fixes #241
    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    a69a5c9 View commit details
    Browse the repository at this point in the history

  14. Make flake8 just print errors instead of dying

    @sverhoeven
    sverhoeven committed Aug 12, 2021
    Copy the full SHA
    6695108 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2021

  1. Fix line lengths in ewatercycle.models

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    ddbd76e View commit details
    Browse the repository at this point in the history

  2. Fix line lengths in config

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    f5b3fc6 View commit details
    Browse the repository at this point in the history

  3. Fix line lengths in ewatercycle.parameter_sets

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    644e14d View commit details
    Browse the repository at this point in the history

  4. fix line lengths in ewatercycle.forcing

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    6786f7a View commit details
    Browse the repository at this point in the history

  5. Fix remaining line lengths in ewatercycle package

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    e6b91cf View commit details
    Browse the repository at this point in the history

  6. noqa instead of pylint-specific

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    0f5bf78 View commit details
    Browse the repository at this point in the history

  7. Fix line lengths in tests

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    8e47e24 View commit details
    Browse the repository at this point in the history

  8. fix error message

    @Peter9192
    Peter9192 committed Aug 16, 2021
    Copy the full SHA
    b0f5f8d View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Force showing of warnings of nbqa-flake8

    @sverhoeven
    sverhoeven committed Aug 17, 2021
    Copy the full SHA
    a6f0436 View commit details
    Browse the repository at this point in the history

  2. Update .pre-commit-config.yaml 

    Co-authored-by: Peter Kalverla <peter.kalverla@gmx.com>
    @sverhoeven @Peter9192
    sverhoeven and Peter9192 committed Aug 17, 2021
    Copy the full SHA
    04723c5 View commit details
    Browse the repository at this point in the history

  3. Merge branch '111-black' of github.com:eWaterCycle/ewatercycle into 1… 

    …11-black
    @sverhoeven
    sverhoeven committed Aug 17, 2021
    Copy the full SHA
    70f957d View commit details
    Browse the repository at this point in the history