Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PCRGlobWB forcing generator #179

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update PCRGlobWB forcing generator #179

wants to merge 2 commits into from

Conversation

Peter9192
Copy link
Collaborator

  • add precipitationVariableName and temperatureVariableName props to PCRGlobWBForcing and in PCRGlobWB set those fields in the config in _setup_default_config() method.

related to eWaterCycle/ewatercycle-pcrglobwb#4

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Peter9192 Peter9192 mentioned this pull request Jul 15, 2021
Open
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Peter9192
Copy link
Collaborator Author

@sverhoeven feel free to hack on this branch if there's anything in it you can use for #164 or eWaterCycle/ewatercycle-pcrglobwb#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Peter9192