Trapping resolve #500
Merged
Trapping resolve #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tentative WIP, if I understand the role of PQ. Previously, relied on a nonstandard ordering of polynomial terms Creates helper function _build_lib_info() that calculates a lot of useful structures for navigating the terms of a polynomial library
Jacob-Stevens-Haas
force-pushed
the
trapping-resolve
branch
from
7b24642
to
7f673d7
Compare
Jacob-Stevens-Haas
force-pushed
the
trapping-resolve
branch
from
7f673d7
to
3019307
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
==========================================
+ Coverage 94.68% 94.70% +0.01%
==========================================
Files 38 38
Lines 4081 4114 +33
==========================================
+ Hits 3864 3896 +32
- Misses 217 218 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #499, this implements a test for PL and PQ as well as improves those functions and CI.
Implements the fix in 483f8f4.