fix(validators): Stop converting default when is_type_of is set to str #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a validator defines both `is_type_of=str, default="0.30"` the validation process SHOULD NOT convert the default to a float, so the current solution was to bypass toml by adding extra quotes. NOTE: Future solution, in 4.0.0 will be to decouple defaults declaration from validation declaration, and completely remove the tomlfy function fix: #1064
✅ Deploy Preview for dynaconf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 23 23
Lines 2248 2248
=======================================
Hits 2220 2220
Misses 28 28 ☔ View full report in Codecov by Sentry. |
rochacbruno
force-pushed
the
1064
branch
3 times, most recently
from
49bb460
to
6848bdd
Compare
pedro-psb
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a validator defines both
is_type_of=str, default="0.30"the validation process SHOULD NOT convert the default to a float, so the current solution was to bypass toml by adding extra quotes.NOTE: Future solution, in 4.0.0 will be to decouple defaults declaration from validation declaration, and completely remove the tomlfy function
fix: #1064