Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed vendor_src folder #798

Merged
merged 2 commits into from Sep 4, 2022
Merged

Removed vendor_src folder #798

merged 2 commits into from Sep 4, 2022

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Sep 3, 2022

  1. Removed dynaconf/vendor_src now dynaconf/vendor is the source and minification happens only during release process, this makes debugging on development mode easier.

The number of files on this PR is huge 168, however most of those are vendor files which doesn't need review.

  1. Added dynaconf/vendor/tomllib this is the library to be on std lib on python 3.11, as this is just a reader, added also its counterpart tomli-w as _writter.py

  2. Deprecated the legacy toml library, but kept for backwards compatibility, so now toml_loader will first try to load with tomllib (following 1.0.0 toml spec) and if fails will fallback to toml (following 0.5.0 toml spec)

Now `vendor` is the source
and minification happens during release process.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Test Results (Python 3.8)

364 tests  +1   364 ✔️ +1   33s ⏱️ +3s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 90562be. ± Comparison against base commit 3200c00.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

Test Results (Python 3.10)

364 tests  +1   364 ✔️ +1   33s ⏱️ -9s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 90562be. ± Comparison against base commit 3200c00.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Merging #798 (90562be) into master (3200c00) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #798   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1766      1773    +7     
=========================================
+ Hits          1766      1773    +7     
Impacted Files Coverage Δ
dynaconf/cli.py 100.00% <100.00%> (ø)
dynaconf/loaders/base.py 100.00% <100.00%> (ø)
dynaconf/loaders/toml_loader.py 100.00% <100.00%> (ø)
dynaconf/utils/parse_conf.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

toml kept as a fallback until 4.0.0 to nor break compatibility

- toml follows 0.5.0 spec
- tomlib follows 1.0.0 spec
- toml allows emojis and unicode chars unencoded
- tomllib foolows the spec where only encoded chars are allowed
@rochacbruno rochacbruno merged commit 651ae76 into master Sep 4, 2022
@rochacbruno rochacbruno deleted the vendoring branch September 5, 2022 18:13
rochacbruno added a commit that referenced this pull request Sep 22, 2022
Shortlog of commits since last release:

    Amadou Crookes (1):
          envars.md typo fix (#786)

    Bruno Rocha (19):
          Release version 3.1.9
          Bump dev version to 3.1.10
          Update badges
          demo repo will be replaced by a video tutorial soon
          Fix CI
          New data key casing must adapt to existing key casing (#795)
          Add test and docs about includes (#796)
          Removed vendor_src folder (#798)
          Replacing rochacbruno/ with dynaconf/ (#800)
          Fix codecov (#801)
          Parse negative numbers from envvar Fix #799 and Fix #585 (#802)
          Fix get command with Django (#804)
          Add a functional test runner (#805)
          Test runner docs and styling (#806)
          Allow merge_unique on lists when merge_enabled=True (#810)
          Rebind current env when forced for Pytest Fix #728 (#809)
          AUTO_CAST can be enabled on instance (#811)
          Ensure pyminify is on release script
          Add missing tomllib to monify script

    Gaurav Talreja (1):
          Fix #807 Use client.auth.approle.login instead of client.auth_approle (#808)

    Jitendra Yejare (1):
          Fix #768 of kv property depreciation from client object (#769)

    Joren Retel (2):
          Feature/detect casting comb token from converters (#784)
          Adding documentation and example to makefile. (#791)

    João Gustavo A. Amorim (1):
          Add pyupgrade hook (#759)

    Kian-Meng Ang (1):
          Fix typos (#788)

    Lucas Limeira (1):
          Using filter_strategy in env_loader to fix #760 (#767)

    Nicholas Nadeau, Ph.D., P.Eng (1):
          fix: typo (#766)

    Oleksii Baranov (2):
          Bump codecov action version (#775)
          Fix cli init command for flask (#705) (#774)

    Pedro de Medeiros (1):
          documentation fixes (#771)

    The Gitter Badger (1):
          Add a Gitter chat badge to README.md (#776)

    Théo Melo (1):
          Fixing a typo on the readme file (#763)

    Vicente Marçal (1):
          docs(pt-br): Docs Translation to brazilian portugues. (#787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants