Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Upgrade TOML library to TOML 1.0.0 #708

Closed
FrankBattaglia opened this issue Jan 24, 2022 · 1 comment
Closed

[RFC] Upgrade TOML library to TOML 1.0.0 #708

FrankBattaglia opened this issue Jan 24, 2022 · 1 comment
Assignees
@rochacbruno
Labels
Not a Bug Not a Problem, expected behavior RFC
Milestone
3.1.10

Comments

@FrankBattaglia
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I would like to use features of the TOML 1.0.0 specification, but the current vendored library is only compatible with v0.5.0

Describe the solution you'd likeUpdate the vendored library to one that is compatible with TOML 1.0.0. See e.g. https://github.com/toml-lang/toml/wiki#v100-compliant

Describe alternatives you've considered
Don't use v1.0.0 features, which makes the TOML file less expressive

Additional context
(specifically, mixed-type arrays)
@FrankBattaglia FrankBattaglia added Not a Bug Not a Problem, expected behavior RFC labels Jan 24, 2022
@rochacbruno rochacbruno modified the milestones: 3.2.0, 3.1.8 Mar 31, 2022
@rochacbruno rochacbruno modified the milestones: 3.1.9, 3.2.0 Jun 2, 2022
@rochacbruno rochacbruno self-assigned this Sep 3, 2022
rochacbruno added a commit that referenced this issue Sep 4, 2022
@rochacbruno
Added tomllib (vendored) as a replacement for toml fix #708
90562be 
toml kept as a fallback until 4.0.0 to nor break compatibility

- toml follows 0.5.0 spec
- tomlib follows 1.0.0 spec
- toml allows emojis and unicode chars unencoded
- tomllib foolows the spec where only encoded chars are allowed
@rochacbruno
Copy link
Member

#798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rochacbruno rochacbruno

Labels
Not a Bug Not a Problem, expected behavior RFC
Projects
None yet
Milestone
3.1.10
Development

No branches or pull requests
2 participants
@FrankBattaglia @rochacbruno