Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chardet rather than charset_normalizer #471

Merged
merged 2 commits into from Jul 14, 2021

Conversation

arcondello
Copy link
Member

Otherwise multipart upload gets dwave.cloud.exceptions.ProblemUploadError: Multipart upload of problem_id='...' failed for part_no=1 with InvalidAPIResponseError('JSON response expected').

@arcondello arcondello requested a review from hhtong July 14, 2021 17:30
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #471 (8d86add) into master (d06aaaa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files          16       16           
  Lines        2637     2637           
=======================================
  Hits         2201     2201           
  Misses        436      436           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d06aaaa...8d86add. Read the comment docs.

@hhtong hhtong merged commit a3dec89 into dwavesystems:master Jul 14, 2021
@arcondello
Copy link
Member Author

arcondello commented Jul 14, 2021

See also psf/requests#5871 (just posted a few hours ago).
I imagine there is a more elegant fix, by specifying the encoder explicitly.

hhtong pushed a commit that referenced this pull request Jul 14, 2021
Fixes
---

- Specify use of chardet to fix the multipart upload error introduced with requests==2.26.0 (#471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants