-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish CommonJS modules rather than a UMD bundle #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottsj
force-pushed
the
no-umd
branch
3 times, most recently
from
November 20, 2019 17:41
48525f7
to
0f10e67
Compare
crhayes
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dope... learned a few things regarding bundling packages 🔥
src/skeleton.js
Outdated
@@ -61,7 +61,8 @@ export default function Skeleton({ | |||
elements.push( | |||
<span | |||
key={i} | |||
className={`${skeletonClass} react-loading-skeleton`} | |||
className="react-loading-skeleton" | |||
css={skeletonStyles} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice change 👍
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes here (apologies for the combo PR; let me know if I should split into invididual PRs):
BREAKING CHANGE: Publish regular CommonJS modules compiled via
@babel/cli
, rather than bundling with webpack. This enables react-loading-skeleton to work in server-side render environments like Next.js, because bundling issues like these are avoided:Switch from
emotion
to@emotion/core
: https://emotion.sh/docs/migrating-to-emotion-10Upgrade all dependencies to latest
Use
@emotion/babel-preset-css-prop
. This includesbabel-plugin-emotion
, which performs several optimizations for emotion components.Update Jest tests. With the
css
prop, we can't rely on generated classnames anymore, so this code no longer works: