Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.10 tests #102

Closed
wants to merge 13 commits into from
Closed

Add Python 3.10 tests #102

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f6389d8
Update test.yml
Kludex Oct 1, 2021
86548a8
Update test.yml
Kludex Oct 1, 2021
7ae816a
Update .github/workflows/test.yml
Kludex Oct 1, 2021
9a74e41
Update test.yml
Kludex Oct 1, 2021
3fcba4a
Update test.yml
Kludex Oct 1, 2021
09871bc
Fix pipeline
Kludex Oct 3, 2021
8c3db9f
Add 3.10 to tox envlist
Kludex Oct 3, 2021
792fce1
Add support for Windows
Kludex Oct 3, 2021
355de6b
Remove version specification
Kludex Oct 3, 2021
57724b4
Add tox-gh-actions
Kludex Oct 3, 2021
996d1f9
Upgrade pytest
Kludex Oct 3, 2021
e328011
Fix pytest version
Kludex Oct 3, 2021
a9e03bb
undo import
Kludex Oct 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
---
name: Tests
on: [push]
on: [push, pull_request]
jobs:
linux-tests:
name: Python ${{matrix.python-version}} tests on Linux
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9", "pypy3"]
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10.0-rc.3", "pypy3"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesterday I struggled quite some time to get the name right for Github Action. You should use something like: 3.10.0-alpha - 3.10.0. But then you should make sure tox understands you ok. You can take a look to this commit for some "inspiration": psycopg/psycopg@ce86d80

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but the alpha release is old... 🤔

https://www.python.org/dev/peps/pep-0619/#schedule

I guess you'd want to add the latest 3.10 on psycopg.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a range: it should select the most up-to-date version within the range. It picked up the rc2.

Copy link
Author

@Kludex Kludex Oct 1, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Cool!

I'm trying this before: https://github.com/adamchainz/patchy/blob/main/.github/workflows/main.yml

If it doesn't work, I'll pursuit the solution what you did.

EDIT: It didn't work.
EDIT2: it did work with some conditions.

Kludex marked this conversation as resolved.
Show resolved Hide resolved

steps:
- name: Checkout repos
Expand Down