[Fix rubocop#9674] Disable Style/AsciiComments by default.

dvandersluis · Aug 26, 2021 · 98fab60 · 98fab60
1 parent 93e6afc
commit 98fab60
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 22 deletions.
diff --git a/changelog/change_disable_styleasciicomments_by_default.md b/changelog/change_disable_styleasciicomments_by_default.md
@@ -0,0 +1 @@
+* [#9674](https://github.com/rubocop/rubocop/issues/9674): Disable `Style/AsciiComments` by default. ([@dvandersluis][])
diff --git a/config/default.yml b/config/default.yml
@@ -2831,9 +2831,9 @@ Style/ArrayJoin:
 Style/AsciiComments:
   Description: 'Use only ascii symbols in comments.'
   StyleGuide: '#english-comments'
-  Enabled: true
+  Enabled: false
   VersionAdded: '0.9'
-  VersionChanged: '0.52'
+  VersionChanged: '<<next>>'
   AllowedChars:
     - ©
 

diff --git a/lib/rubocop/cop/naming/ascii_identifiers.rb b/lib/rubocop/cop/naming/ascii_identifiers.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Style/AsciiComments
-
 module RuboCop
   module Cop
     module Naming
@@ -90,4 +88,3 @@ def first_non_ascii_chars(string)
     end
   end
 end
-# rubocop:enable Style/AsciiComments
diff --git a/lib/rubocop/cop/style/ascii_comments.rb b/lib/rubocop/cop/style/ascii_comments.rb
@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-# rubocop:disable Style/AsciiComments
-
 module RuboCop
   module Cop
     module Style
@@ -57,4 +55,3 @@ def allowed_non_ascii_chars
     end
   end
 end
-# rubocop:enable Style/AsciiComments
diff --git a/spec/fixtures/html_formatter/expected.html b/spec/fixtures/html_formatter/expected.html
@@ -367,14 +367,14 @@ <h1 class="title">RuboCop Inspection Report</h1>
       <div class="infobox">
         <div class="total">
           3 files inspected,
-          23 offenses detected:
+          22 offenses detected:
         </div>
         <ul class="offenses-list">
 
 
             <li>
               <a href="#offense_app/controllers/application_controller.rb">
-                app/controllers/application_controller.rb - 2 offenses
+                app/controllers/application_controller.rb - 1 offense
               </a>
             </li>
 
@@ -400,7 +400,7 @@ <h1 class="title">RuboCop Inspection Report</h1>
 
       <div class="offense-box" id="offense_app/controllers/application_controller.rb">
         <div class="box-title-placeholder"><h3>&nbsp;</h3></div>
-        <div class="box-title"><h3>app/controllers/application_controller.rb - 2 offenses</h3></div>
+        <div class="box-title"><h3>app/controllers/application_controller.rb - 1 offense</h3></div>
         <div class="offense-reports">
 
           <div class="report">
@@ -414,17 +414,6 @@ <h1 class="title">RuboCop Inspection Report</h1>
 
           </div>
 
-          <div class="report">
-            <div class="meta">
-              <span class="location">Line #6</span> –
-              <span class="severity convention">convention:</span>
-              <span class="message">Style/AsciiComments: Use only ascii symbols in comments.</span>
-            </div>
-
-            <pre><code>  # <span class="highlight convention">“</span>Test encoding issues by using curly quotes”</code></pre>
-
-          </div>
-
         </div>
       </div>