[Fix rubocop#9140] Fix an error for Layout/EmptyLinesAroundArguments

Fixes rubocop#9140. This PR fixes an error for `Layout/EmptyLinesAroundArguments` when multiline style argument for method call without selector.
dvandersluis · Dec 2, 2020 · 0849d36 · 0849d36
1 parent c0f6b9d
commit 0849d36
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/changelog/fix_an_error_for_layout_empty_lines_around_arguments.md b/changelog/fix_an_error_for_layout_empty_lines_around_arguments.md
@@ -0,0 +1 @@
+* [#9140](https://github.com/rubocop-hq/rubocop/issues/9140): Fix an error for `Layout/EmptyLinesAroundArguments` when multiline style argument for method call without selector. ([@koic][])
diff --git a/lib/rubocop/cop/layout/empty_lines_around_arguments.rb b/lib/rubocop/cop/layout/empty_lines_around_arguments.rb
@@ -59,7 +59,7 @@ def on_send(node)
         private
 
         def receiver_and_method_call_on_different_lines?(node)
-          node.receiver && node.receiver.loc.last_line != node.loc.selector.line
+          node.receiver && node.receiver.loc.last_line != node.loc.selector&.line
         end
 
         def empty_lines(node)

diff --git a/spec/rubocop/cop/layout/empty_lines_around_arguments_spec.rb b/spec/rubocop/cop/layout/empty_lines_around_arguments_spec.rb
@@ -292,6 +292,14 @@ def anything; end
       RUBY
     end
 
+    it 'accepts multiline style argument for method call without selector' do
+      expect_no_offenses(<<~RUBY)
+        foo.(
+          arg
+        )
+      RUBY
+    end
+
     context 'with one argument' do
       it 'ignores empty lines inside of method arguments' do
         expect_no_offenses(<<~RUBY)