Remove embed option. Remove public sharing of dashboards. Allow DML q… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start Parameters Migration * Add dirtyCount * Use workaround with setState * Apply Changes * Add EditSettingsDialog * Add Cmd/Ctrl + Enter behavior * Remove isApplying * Delete Angular version of parameters * Update tests * Remove angular stuff * Update jest * Drag placeholder * Update events * Use old button styling and move css * Reviewing code * Add parameter rearrange test * Add Parameter Settings title change test * Update Parameter Settings button styling * Move parameter url logic back to Parameters * Disable url update when query is new * Styling changes (getredash#4019) * Ran's title width styling * Update drag test * Improve sizing for Number inputs Co-Authored-By: Ran Byron <ranbena@gmail.com> * Fix issue with dragged parameter wrapping Co-Authored-By: Ran Byron <ranbena@gmail.com> * Don't reevaluate dirtyParamCount * Allow multiple values :) * Fix parameter alignments * Fix Select width on search * Update client/app/components/Parameters.less Co-Authored-By: Ran Byron <ranbena@gmail.com> * Humanize param.name * Make sure angular updates Execute disabled status
* Add more flake8 tests and fail build if any test fails Run all flake8 E9xx + F63x + F7xx + F82x tests. * long = long in Python 2
* Move connection logic into a single method & make sure not to pass ssl value if not used. * Remove wildcard import and format file.
(some data sources might return None as the columns list)
…sh#4091) * [Data Sources] Add: Azure Data Explorer (Kusto) query runner * CodeClimate fixes * Remove TODO * Fixed configuration properties names for Azure Kusto * Azure Kusto: get_schema in one query * azure-kusto-data update to 0.0.32 * Add Kusto to the default query runners list
…4066) * [Qubole] - Adding support to process Quantum query types. Quantum is a serverless interactive service that offers direct SQL access to user's data lake. Changes are made to accept `quantum` query type from user which makes `Cluster Label` as optional. * -Making quantum as defult query. -Dictionary safe access to connection parmeters * keeping pep8 standards * Maintainig pep8 std * Use latest version of qds-sdk * Use qds-sdk v1.13.0 * Use qds-sdk v1.12.0 * Use qds-sdk v1.13.0 * Updating SDK with verified version * hive as default query type * qds-sdk : Locking most recent release version * qds-sdk : Locking recent release version * falling back to original version of qds-sdk
…dash#3804) * refresh only affected queries in dashboard when parameters are changed * rename pendingParameters to updatedParameters * select which widgets to update according to their mapping as a dashboard-level parameter * use lodash's include
* Update README.md * Update README.md * Update README.md Co-Authored-By: Ran Byron <ranbena@gmail.com> * Update README.md
…ults (getredash#4112) * Fix: allow users with view only acces to access the queries * Add tests * Update error message * Update error message. Take 2
* Code formatting * Move annotation logic into query runner, so it can be overriden in the query runner. * Add mixin to __all__ * Switch to flag instead of mixin * Feature (Redshift): option to set query group for adhoc/scheduled queries (getredash#4114) * Add scheduled status to query job metadata. * Add: option to set query group for adhoc/scheduled Redshift queries * Scheduled might not be set for already enqueued queries.
* Table viz horizontal scroll made visible * Added tests * Fixed snapshot pre-condition * Perhaps this would trigger percy
* Update sentry-sdk version * Add additional Sentry integrations
* Migrate Counter to React: Renderer * Migrate Counter to React: Editor * Cleanup * Review and fix rows indexing algorithm * Counter not properly scaled in editor * Fix wrong label for/input id pair * Tests * Tests * Fix vendor prefixes * Remove unnecessary useEffect dependencies * Update tests * Fix Percy snapshot names
* Added tests * Perhaps this would trigger percy * Decrease size of widget pagination * Removed unused attr * Updated tests
…sh#4071) * getredash#2629 Refactor Chart visualization, add option for handling NULL values (keep/convert to 0.0) * Handle null values in line/area stacking code; some cleanup * Handle edge case: line/area stacking when last value of one of series is missing * Mjnor update to line/area stacking code * Fix line/area normalize to percents feature * Unit tests * Refine tests; add tests for prepareLayout function * Tests for prepareData (heatmap) function * Tests for prepareData (pie) function * Tests for prepareData (bar, line, area) function * Tests for prepareData (scatter, bubble) function * Tests for prepareData (box) function * Remove unused file
* getredash#4132 Add more condition comparison options * Add arguments to fallback lambda
* Migrate Chart visualization: Renderer * Refine PlotlyChart component; move stylesheets to visualization's folder * Migrate Custom JS Chart to React * Cleanup
* CHANGELOG for V8-beta. * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md
…etredash#4144) * Snippets: Don't change url when not needed * Revert "Snippets: Don't change url when not needed" This reverts commit 2f346f3. * Query Snippets: use onClick instead of link
* Fix: widget filters overlapped by visualization * Fix tests * Fix tests
* Stop building tarballs. * Update version reference. * CHANGELOG for 8.0.0-beta.2
…S credentials. (getredash#4345) Without this upgrades from at least v5 (and earlier) won't work.
…ndas to allow clean install against vanilla Python 2.7.17 (getredash#4287)
* Add CHANGELOG entry for v8.0.1 * Update version in __init__.py * Update version in package.json
…ueries in Athena. Add updates on redash home page.
…to homepage. Change default table size rows to 50
masterlittle
force-pushed
the
feature/remove-access-to-public-dashboard
branch
from
f4d0c91
to
bbf8017
Compare
| connection = psycopg2.connect( | ||
| user=self.configuration.get('user'), | ||
| password=self.configuration.get('password'), | ||
| host=self.configuration.get('host'), | ||
| port=self.configuration.get('port'), | ||
| dbname=self.configuration.get('dbname'), | ||
| sslmode=self.configuration.get('sslmode'), | ||
| async_=True) | ||
| async_=True, | ||
| options=statement_timeout) |
There was a problem hiding this comment.
https://github.com/dunzoit/redash/pull/1/files#diff-dde7cbb7478209741ff7cb6f872023c8L189
Shouldnt we add timeout here
_wait(connection, timeout=QUERY_TIMEOUT)
krishna-dunzo
approved these changes
Mar 5, 2020
| @@ -49,8 +49,8 @@ function getDefaultFormatOptions(column) { | |||
| datetime: clientConfig.dateTimeFormat || 'DD/MM/YYYY HH:mm', | |||
| }; | |||
| const numberFormat = { | |||
| integer: clientConfig.integerFormat || '0,0', | |||
| float: clientConfig.floatFormat || '0,0.00', | |||
| integer: clientConfig.integerFormat || '00', | |||
|
Looks good except one comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ueries in Athena. Add updates on redash home page.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)