Define all Cookie arguments explicitly #58
Conversation
This adds support for Symfony 4.2, which deprecates not defining all the arguments as some of their default values are scheduled to change in Symfony 5.0.
iambrosi
force-pushed
the
symfony-42-support
branch
from
5a821bb
to
e35b921
Compare
|
Any news on this? |
|
@dunglas Could you please take a look at this? |
This is the default value as of Symfony 4.2, and makes cookies safer as they won't be sent along with cross-site requests. Also, added missing prediction when registering the cookie in the ResponseHeaderBag.
|
@dunglas Is this ready to be merged? |
|
Can you check why AppVeyor is red? |
|
Travis is not red. AppVeyor is. It cannot find the path to |
|
Can you try to replace php72 by php73 please? It should fix the build. |
|
@iambrosi you can probably revert that last commit and just change the Looks like even in your earlier builds it was pulling 7.3 and then failing, and when upgrading a dependency is looking for PHP < 7.3 |
This ensures appveyor uses PHP 7.2 and not a default version(currently 7.3)
iambrosi
force-pushed
the
symfony-42-support
branch
from
0a639d2
to
f22250f
Compare
|
@dunglas Tests in AppVeyor have been fixed. Thanks @sparksterz for the tip! Also, fixed a new spec failure by a new method call added in symfony/symfony#29944 |
|
Bump @dunglas. Is there any blocker to merging this PR? |
|
Thanks @iambrosi |
This adds support for Symfony 4.2, which deprecates not defining all the arguments as some of their default values are scheduled to change in Symfony 5.0.