New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1343

Merged

joshliebe merged 1 commit into develop from feature/josh/update-dependencies

Aug 10, 2021

Contributor

joshliebe commented Aug 2, 2021 •

edited

Task/Issue URL: https://app.asana.com/0/414730916066338/1200704810752766/f
Tech Design URL:
CC:

Description:
Updates the following dependencies:

version.androidx.appcompat=1.3.0 → 1.3.1
version.androidx.constraintlayout=2.0.4 → 2.1.0
version.androidx.fragment=1.3.5 → 1.3.6
version.androidx.test=1.4.0-beta02 → 1.4.0
version.google.dagger=2.37 → 1.5.21

Steps to test this PR:

All unit tests should pass.
Run through the app and check that there isn't any unexpected behavior.

Smoke test (Steps copied from #1299, thanks @cmonfortep):

Onboarding CTAs
Add bookmarks and favorites
Disable/enable privacy protection
Share feedback
Fireproof a site and clear all data
Opening multiple tabs (and closing tabs + undo)

I tested on API 21 and 30.

Internal references:

Software Engineering Expectations
Technical Design Template


          Update dependencies

4a29b9b

aitorvs self-assigned this

aitorvs approved these changes

View reviewed changes

Collaborator

aitorvs left a comment

Tested as per description. All looks good!

Contributor Author

joshliebe commented Aug 10, 2021

Thanks for the review @aitorvs! 👍

joshliebe merged commit c1c2860 into develop

joshliebe deleted the feature/josh/update-dependencies branch

August 10, 2021 11:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment