feat: allow extensions to implement CREATE/DROP DATABASE #6115
+18,475
−18,723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Feb 7, 2023
There was a problem hiding this comment.
Thanks for the changes! One more thing that I did not realize before - the code for DROP DATABASE seems to work with the existing DETACH code. These are two distinct concepts that should be kept separate in my opinion. Perhaps we can move the DETACH code to a separate operator instead?
The PR also seems to be missing code that extends the grammar with support for DROP DATABASE. Should that not be added as well?
rjatwal
commented
Feb 13, 2023
| auto result = make_unique<DetachStatement>(); | ||
| auto info = make_unique<DetachInfo>(); | ||
| info->name = stmt->db_name; | ||
| info->if_exists = stmt->missing_ok; |
There was a problem hiding this comment.
Planning to change missing_ok => if_exists
| @@ -100,6 +100,8 @@ string LogicalOperatorToString(LogicalOperatorType type) { | |||
| return "CREATE_SCHEMA"; | |||
| case LogicalOperatorType::LOGICAL_ATTACH: | |||
| return "ATTACH"; | |||
| case LogicalOperatorType::LOGICAL_DETACH: | |||
| return "ATTACH"; | |||
There was a problem hiding this comment.
Is this supposed to return "DETACH"?
There was a problem hiding this comment.
Good catch yes indeed.
|
Thanks! |
stephaniewang526
added a commit
to stephaniewang526/duckdb
that referenced
this pull request
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes PR #6075