fix: pin cython to work around bug #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, that should fix it for real. More painful than I was expecting Just to add some background on why this is required at all - pandas distributes binaries in "wheels" (the joke here being about cheese wheels, if you're curious), but doesn't provide them for all platforms - Windows 32bit being one of them Because no binary is distributed, we have to build from scratch, but the Cython change broke that build. Hence the pin back to a working version to fix it |
|
There are also a couple of |
|
Thanks for the fixes! Agreed that should be fixed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix the build
See scipy/scipy#16718