🐛 Fix safeApply never calling original apply
#3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing verson of the code was wrong as it was expecting `apply` to be directly defined on the called function while in theory it comes from the `Function.prototype`. Given benchmarks we did on https://github.com/dubzzz/fast-check-benchmarks/blob/main/benchmark-poisoning-results.txt, we expect some performance uplift from this change: - before: from 8,572.147 to 8,823.322 ops/sec - after: from 15,083.692 to 15,573.392 ops/sec Measurments on fast-check itself will be carried out before merging the fix to make sure of the performance boost.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 48d4cb5:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fdefee0:
|
|
Performance measurements for current main (dd5b27b) (aka main) vs 3.1.0 (aka 3.1.0) vs this PR (aka extra):
More details at: https://github.com/dubzzz/fast-check-benchmarks/runs/8103484316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing version of the code was wrong as it was expecting
applyto be directly defined on the called function while in theory it comes from theFunction.prototype.Given benchmarks we did on https://github.com/dubzzz/fast-check-benchmarks/blob/main/benchmark-poisoning-results.txt, we expect some performance uplift from this change:
Measurements on fast-check itself will be carried out before merging the fix to make sure of the performance boost.
Category:
Potential impacts: