✅ Check arbitraries do not cause any poisoning #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poisoning is easy to do by mistake. By playing with randomly generated values fast-check could asily and unwantingly clutter the global scope with unwanted poisoned values. The newly added checks make sure that, whenever tested via the arbitraries' assertions, arbitraries will not push any poison to the running code.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a61ba46:
|
dubzzz
commented
Sep 11, 2022
dubzzz
commented
Sep 15, 2022
packages/fast-check/test/unit/arbitrary/__test-helpers__/ArbitraryAssertions.ts
Outdated
Show resolved
Hide resolved
dubzzz
commented
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poisoning is easy to do by mistake. By playing with randomly generated values fast-check could asily and unwantingly clutter the global scope with unwanted poisoned values. The newly added checks make sure that, whenever tested via the arbitraries' assertions, arbitraries will not push any poison to the running code.
Category:
Potential impacts: