Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Export package.json #3066

Merged
merged 2 commits into from Jul 26, 2022
Merged

πŸ› Export package.json #3066

merged 2 commits into from Jul 26, 2022

Conversation

matinzd
Copy link
Contributor

@matinzd matinzd commented Jul 22, 2022

Fixes [ERR_PACKAGE_PATH_NOT_EXPORTED] -> Add package subpath

related to nodejs/node#33460

Category:

  • ✨ Introduce new features
  • πŸ“ Add or update documentation
  • βœ… Add or update tests
  • πŸ› Fix a bug
  • 🏷️ Add or update types
  • ⚑️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 65d4ecb:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@dubzzz
Copy link
Owner

dubzzz commented Jul 22, 2022

Thanks a lot for the fix.

We should probably apply the same for 2 other packages of the monorepo that rely on exports: ava and jest. Things that you or I can do in another PR, another PR so that I can patch and backport the fix more easily for each distinct package.

For the red CI test, you will mostly need to run yarn version:bump and tell yarn that you expect a patch for fast-check.

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #3066 (65d4ecb) into main (e880b0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3066   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files         210      210           
  Lines        5348     5348           
  Branches     1027     1027           
=======================================
  Hits         5134     5134           
  Misses        214      214           
Flag Coverage Ξ”
unit-tests 95.99% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@matinzd
Copy link
Contributor Author

matinzd commented Jul 23, 2022

I just updated two other packages in the same PR. Is that ok for you? @dubzzz

Copy link
Owner

@dubzzz dubzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

.yarn/versions/19173632.yml Outdated Show resolved Hide resolved
.yarn/versions/19173632.yml Outdated Show resolved Hide resolved
@matinzd matinzd changed the title export package.json fix: export package.json Jul 24, 2022
@matinzd
Copy link
Contributor Author

matinzd commented Jul 24, 2022

@dubzzz Done.

@dubzzz dubzzz changed the title fix: export package.json πŸ› Export package.json Jul 26, 2022
@dubzzz dubzzz merged commit a6c154d into dubzzz:main Jul 26, 2022
@matinzd matinzd deleted the patch-1 branch July 26, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants