New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Export package.json #3066
π Export package.json #3066
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 65d4ecb:
|
Thanks a lot for the fix. We should probably apply the same for 2 other packages of the monorepo that rely on exports: ava and jest. Things that you or I can do in another PR, another PR so that I can patch and backport the fix more easily for each distinct package. For the red CI test, you will mostly need to run |
Codecov Report
@@ Coverage Diff @@
## main #3066 +/- ##
=======================================
Coverage 95.99% 95.99%
=======================================
Files 210 210
Lines 5348 5348
Branches 1027 1027
=======================================
Hits 5134 5134
Misses 214 214
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. |
I just updated two other packages in the same PR. Is that ok for you? @dubzzz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
@dubzzz Done. |
Fixes [ERR_PACKAGE_PATH_NOT_EXPORTED] -> Add package subpath
related to nodejs/node#33460
Category:
Potential impacts: