Skip to content

♻️ No more use of window for global configuration #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jun 15, 2021

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 68bf0c8:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@dubzzz dubzzz changed the title ♻️ No more access to window to store global configuration ♻️ No more use of window for global configuration Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #2001 (68bf0c8) into main (e538f55) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
+ Coverage   96.53%   96.65%   +0.11%     
==========================================
  Files         167      166       -1     
  Lines        4189     4216      +27     
  Branches      815      823       +8     
==========================================
+ Hits         4044     4075      +31     
+ Misses        141      137       -4     
  Partials        4        4              
Flag Coverage Δ
unit-tests 96.65% <100.00%> (+0.11%) ⬆️
unit-tests-12.x-Linux 96.65% <100.00%> (+0.11%) ⬆️
unit-tests-14.x-Linux 96.65% <100.00%> (+0.11%) ⬆️
unit-tests-16.x-Linux 96.65% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/check/runner/configuration/GlobalParameters.ts 100.00% <100.00%> (ø)
src/utils/stringify.ts 98.69% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e538f55...68bf0c8. Read the comment docs.

@dubzzz dubzzz merged commit 0748887 into main Jun 15, 2021
@dubzzz dubzzz deleted the no-global branch June 15, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant