Skip to content

⚡️ More performant non-cloneable values in NextValue #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jun 2, 2021

Let's try performance a step further by optimizing the normal case of non-cloneable values in NextValue and Shrinkable.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • Other(s): Increase performances

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

Sorry, something went wrong.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f7e771:

Sandbox Source
Vanilla Configuration
fast-check-examples Configuration

@dubzzz
Copy link
Owner Author

dubzzz commented Jun 2, 2021

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1948 (8f7e771) into main (5367139) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
- Coverage   97.50%   97.47%   -0.03%     
==========================================
  Files         166      166              
  Lines        4122     4124       +2     
  Branches      802      805       +3     
==========================================
+ Hits         4019     4020       +1     
- Misses         99      100       +1     
  Partials        4        4              
Flag Coverage Δ
unit-tests 97.47% <100.00%> (-0.03%) ⬇️
unit-tests-10.x-Linux 97.47% <100.00%> (-0.03%) ⬇️
unit-tests-12.x-Linux 97.47% <100.00%> (-0.03%) ⬇️
unit-tests-14.x-Linux 97.47% <100.00%> (-0.03%) ⬇️
unit-tests-16.x-Linux 97.47% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/check/arbitrary/definition/NextValue.ts 94.11% <100.00%> (-5.89%) ⬇️
src/check/arbitrary/definition/Shrinkable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5367139...8f7e771. Read the comment docs.

@dubzzz dubzzz merged commit a7547d7 into main Jun 2, 2021
@dubzzz dubzzz deleted the perf-non-cloneable branch June 2, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant