Drop basic-toml in favor of more widely used toml crate #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csnover
added a commit
to csnover/trybuild
that referenced
this pull request
Mar 30, 2024
Replacing basic-toml crate in dtolnay#239 raised MSRV to 1.67 (toml_datetime specifies this minimum), but CI workflow was updated to 1.70 in that PR, so this patch raises MSRV to 1.70 instead. A reference to even older MSRV in the README is removed entirely since this information lives in Cargo.toml as of Rust 1.56.
csnover
added a commit
to csnover/binrw
that referenced
this pull request
Mar 30, 2024
Upstream switched from basic-toml to toml in dtolnay/trybuild#239 which leads to a dependency on toml_datetime which has an MSRV of Rust 1.67; since this is just a dev-dependency, there is no reason to increase MSRV, so just pin the trybuild dependency to the previous version until there is some new feature that requires raising binrw MSRV again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257.