Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Multiple applicable provide methods in scope" #190

Merged
merged 6 commits into from Sep 13, 2022
Merged

Fix "Multiple applicable provide methods in scope" #190

merged 6 commits into from Sep 13, 2022

Commits on Sep 13, 2022

  1. Move multiple-provide test into test_backtrace 

    Currently fails with:

    error[E0034]: multiple applicable items in scope
       --> tests/test_backtrace.rs:165:13
        |
    165 |             x: std::io::Error,
        |             ^ multiple `provide` found
        |
        = note: candidate #1 is defined in an impl of the trait `Provider` for the type `E`
        = note: candidate #2 is defined in an impl of the trait `std::error::Error` for the type `std::io::Error`
    help: disambiguate the associated function for candidate #1
        |
    165 |             Provider::provide(&x, Error): std::io::Error,
        |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    help: disambiguate the associated function for candidate #2
        |
    165 |             std::error::Error::provide(&x, Error): std::io::Error,
        |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    @dtolnay
    dtolnay committed Sep 13, 2022
    Copy the full SHA
    21198c9 View commit details
    Browse the repository at this point in the history

  2. Revert "Directly call source.provide instead of going through dyn error" 

    This reverts commit f924c25.
    @dtolnay
    dtolnay committed Sep 13, 2022
    Copy the full SHA
    3bcad59 View commit details
    Browse the repository at this point in the history

  3. Add build script to detect Provider support

    @dtolnay
    dtolnay committed Sep 13, 2022
    Copy the full SHA
    293b127 View commit details
    Browse the repository at this point in the history

  4. Add trait with method that won't collide between Provider and Error

    @dtolnay
    dtolnay committed Sep 13, 2022
    Copy the full SHA
    460396e View commit details
    Browse the repository at this point in the history

  5. Use ThiserrorProvide to disambiguate 'provide' method calls

    @dtolnay
    dtolnay committed Sep 13, 2022
    Copy the full SHA
    aaf8449 View commit details
    Browse the repository at this point in the history

  6. Temporarily disable AnyhowBacktrace test

    @dtolnay
    dtolnay committed Sep 13, 2022
    Copy the full SHA
    01e7c18 View commit details
    Browse the repository at this point in the history