Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound generic for Error and Display impls #107

Closed
wants to merge 1 commit into from
Closed

Bound generic for Error and Display impls #107

wants to merge 1 commit into from

Conversation

jsim2010
Copy link

@jsim2010 jsim2010 commented Oct 28, 2020 •
edited

Allows for functionality similar to what is described in #79 although without a #[from].

I have not used syn very extensively so there might be a better way to build the impl_generics.

@vikigenius vikigenius mentioned this pull request May 2, 2021
Closed
dtolnay
dtolnay reviewed May 22, 2021
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows for functionality similar to what is described in #79 although without a #[from].

My comments in #79 are still how I want the issue addressed, so I'll go ahead and close this. Blindly bounding every type parameter is not sufficient.

Thanks anyway!

@dtolnay dtolnay closed this May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsim2010 @dtolnay