Skip to content

Commit

Permalink
Merge pull request #189 from dtolnay/sealed
Browse files Browse the repository at this point in the history
Add Sealed supertrait to private AsDynError trait
  • Loading branch information
dtolnay committed Sep 13, 2022
2 parents c6b8fcf + 85d812f commit 12acbc5
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
14 changes: 13 additions & 1 deletion src/aserror.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
use self::private::Sealed;
use std::error::Error;
use std::panic::UnwindSafe;

pub trait AsDynError<'a> {
pub trait AsDynError<'a>: Sealed {
fn as_dyn_error(&self) -> &(dyn Error + 'a);
}

Expand Down Expand Up @@ -39,3 +40,14 @@ impl<'a> AsDynError<'a> for dyn Error + Send + Sync + UnwindSafe + 'a {
self
}
}

mod private {
use super::*;

pub trait Sealed {}
impl<'a, T: Error + 'a> Sealed for T {}
impl<'a> Sealed for dyn Error + 'a {}
impl<'a> Sealed for dyn Error + Send + 'a {}
impl<'a> Sealed for dyn Error + Send + Sync + 'a {}
impl<'a> Sealed for dyn Error + Send + Sync + UnwindSafe + 'a {}
}
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@
clippy::doc_markdown,
clippy::module_name_repetitions,
clippy::return_self_not_must_use,
clippy::wildcard_imports,
)]

mod aserror;
Expand Down

0 comments on commit 12acbc5

Please sign in to comment.