Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe mod and foreign mod #938

Closed

Conversation

adetaylor
Copy link

No description provided.

@taiki-e
Copy link
Contributor

taiki-e commented Dec 5, 2020

(Note that parsing for these syntaxes is already supported (#928, #929). Adding a field is a breaking change, so currently parsed as Item::Verbatim.)

@adetaylor
Copy link
Author

@taiki-e Thanks! Unfortunately I am generating code for input into https://github.com/dtolnay/cxx, so I was looking for full syn functionality. But you're right: I think I should generate Item::Verbatim too (I'm doing that in one other place, it's not too bad! - and I can probably do it by trivially modifying an ItemMod made by syn anyway)

It's clear from #928, #929 plus the PR builder results that this PR requires a bit more work. I'll close it for now and reopen it when it's spruced up, ready to land eventually next time there's a breaking release of syn.

@adetaylor adetaylor closed this Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants