Make ParseBuffer unwindsafe #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently fails to build:
error[E0277]: the type `UnsafeCell<syn::buffer::Cursor<'static>>` may contain interior mutability and a reference may not be safely transferrable across a catch_unwind boundary
--> tests/test_parse_buffer.rs:98:49
|
98 | let thread_result = panic::catch_unwind(|| input.parse());
| ------------------- ^^^^^^^^^^^^^^^^ `UnsafeCell<syn::buffer::Cursor<'static>>` may contain interior mutability and a reference may not be safely transferrable across a catch_unwind boundary
| |
| required by a bound introduced by this call
|
= help: within `ParseBuffer<'_>`, the trait `RefUnwindSafe` is not implemented for `UnsafeCell<syn::buffer::Cursor<'static>>`, which is required by `{closure@tests/test_parse_buffer.rs:98:49: 98:51}: UnwindSafe`
note: required because it appears within the type `Cell<syn::buffer::Cursor<'static>>`
--> $RUST/library/core/src/cell.rs:293:12
|
293 | pub struct Cell<T: ?Sized> {
| ^^^^
note: required because it appears within the type `ParseBuffer<'_>`
--> src/parse.rs:245:12
|
245 | pub struct ParseBuffer<'a> {
| ^^^^^^^^^^^
= note: required for `&ParseBuffer<'_>` to implement `UnwindSafe`
note: required because it's used within this closure
--> tests/test_parse_buffer.rs:98:49
|
98 | let thread_result = panic::catch_unwind(|| input.parse());
| ^^
note: required by a bound in `std::panic::catch_unwind`
--> $RUST/library/std/src/panic.rs:148:40
|
148 | pub fn catch_unwind<F: FnOnce() -> R + UnwindSafe, R>(f: F) -> Result<R> {
| ^^^^^^^^^^ required by this bound in `catch_unwind`
error[E0277]: the type `UnsafeCell<Option<Rc<Cell<parse::Unexpected>>>>` may contain interior mutability and a reference may not be safely transferrable across a catch_unwind boundary
--> tests/test_parse_buffer.rs:98:49
|
98 | let thread_result = panic::catch_unwind(|| input.parse());
| ------------------- ^^^^^^^^^^^^^^^^ `UnsafeCell<Option<Rc<Cell<parse::Unexpected>>>>` may contain interior mutability and a reference may not be safely transferrable across a catch_unwind boundary
| |
| required by a bound introduced by this call
|
= help: within `ParseBuffer<'_>`, the trait `RefUnwindSafe` is not implemented for `UnsafeCell<Option<Rc<Cell<parse::Unexpected>>>>`, which is required by `{closure@tests/test_parse_buffer.rs:98:49: 98:51}: UnwindSafe`
note: required because it appears within the type `Cell<Option<Rc<Cell<parse::Unexpected>>>>`
--> $RUST/library/core/src/cell.rs:293:12
|
293 | pub struct Cell<T: ?Sized> {
| ^^^^
note: required because it appears within the type `ParseBuffer<'_>`
--> src/parse.rs:245:12
|
245 | pub struct ParseBuffer<'a> {
| ^^^^^^^^^^^
= note: required for `&ParseBuffer<'_>` to implement `UnwindSafe`
note: required because it's used within this closure
--> tests/test_parse_buffer.rs:98:49
|
98 | let thread_result = panic::catch_unwind(|| input.parse());
| ^^
note: required by a bound in `std::panic::catch_unwind`
--> $RUST/library/std/src/panic.rs:148:40
|
148 | pub fn catch_unwind<F: FnOnce() -> R + UnwindSafe, R>(f: F) -> Result<R> {
| ^^^^^^^^^^ required by this bound in `catch_unwind`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParseBuffer contains interior mutability, but there isn't any way to get it into some invalid state by panicking in user code.