Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse gen blocks and functions #1549

Closed
wants to merge 1 commit into from
Closed

Parse gen blocks and functions #1549

wants to merge 1 commit into from

Conversation

mohe2015
Copy link

@mohe2015 mohe2015 marked this pull request as ready for review December 19, 2023 18:12
@mohe2015
Copy link
Author

mohe2015 commented Dec 19, 2023 •
edited

Seems like some tests fail because gen is now a keyword. I don't know how to fix this so feel free to make changes if you want to or give advice on how I can fix this myself. Otherwise this is just a partially finished PR.

dtolnay
dtolnay reviewed Dec 22, 2023
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This would need to be closer to stabilization before I would consider adding a syntax tree node for it. The syntax only just got introduced in rustc.

@dtolnay dtolnay closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mohe2015 @dtolnay